Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/marp 578 handling feedback release vertex ai connector #14

Conversation

tvtphuc-axonivy
Copy link
Collaborator

No description provided.

Copy link

Test Results

12 tests  ±0   12 ✅ ±0   8s ⏱️ ±0s
 2 suites ±0    0 💤 ±0 
 2 files   ±0    0 ❌ ±0 

Results for commit 2be6aa9. ± Comparison against base commit b28cb2d.

Copy link

github-actions bot commented Jul 24, 2024

Test Results

12 tests  ±0   12 ✅ ±0   8s ⏱️ ±0s
 2 suites ±0    0 💤 ±0 
 2 files   ±0    0 ❌ ±0 

Results for commit 9475206. ± Comparison against base commit b28cb2d.

♻️ This comment has been updated with latest results.

Copy link
Member

@ivy-rew ivy-rew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement; I like this variables definition a lot 🚀

@ivy-rew
Copy link
Member

ivy-rew commented Jul 24, 2024

Please take of your commit history, we have now 16 commits for a simple documentation improvement.
I suggest to squash them and give it meaningful name.

Copy link

@nntthuy-axonivy nntthuy-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvtphuc-axonivy tvtphuc-axonivy merged commit be481bd into master Jul 25, 2024
4 checks passed
@tvtphuc-axonivy tvtphuc-axonivy deleted the feature/MARP-578-Handling-feedback-release-Vertex-AI-connector branch July 25, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants